Replication:
- Add a Keypress to a command
- Observe "Press And Release Key(s)" "Hold down for" value, set to non-zero if it isn't already
- Change to "Press Key(s)" or "Release Key(s)"
- Click OK
- Edit added keypress
- Observe "Press And Release Key(s)" "Hold down for" value, this will now be "00,000", and remain such even when switching back to "Press And Release Key(s)"
The last value edited will always be saved. If you edit a keypress set to "Press And Release Key(s)" which has a non-zero value, that will be saved when clicking "OK".
The issue occurs when editing a "Press Key(s)" or "Release Key(s)" keypress, which does not have a value saved to retrieve.
From the fact that a new keypress created as "Press And Release Key(s)" retains the last value, it should be possible to populate the "Hold down for" field using this "cached" value instead of retrieving it from the current keypress, if "Press And Release Key(s)" is not the stored action when editing the keypress.
I was going to suggest adding a check to only save the "cached" value when "Press And Release Key(s)" is selected to the "Edit a Keypress" "OK" button, but if you populate the field using said "cached" value you don't strictly have to(Although, is it better to keep the "cached" value, which could be more relevant for a new keypress, if an edit is made to the "Hold down for" value, even if "Press And Release Key(s)" is not selected and thus said value will not be used? I leave that up to you).
EDIT:
Originally spotted in v1.5.8.18
Tested with v1.5.8.19, still in place.
Topic: [v1.5.8.19] Keypress "Hold down for" time lost if not using "Press And Release" (Read 4788 times)