[1.6.1.27] CMDSEGMENT not working as expected

[TheThingIs]

If one of the segments doesn't get said then all of them are returned as not set. I would have thought that only the part not said would be not set

eg
[engines;shields;systems;weapons] and [then;] [engines;shields;systems;weapons]

saying 'engines and weapons' returns all 4 segments as not set

saying 'engines and then weapons' returns correctly 'engines' 'and' 'then' 'weapons'

[Gary]

I'll take a look at it.

[Gary]

Ah... I see what's up.  Stupid programmer issue.  I'll have at least an, 'unofficial' out in a bit.


Edit:  There's a build out in, 'unofficial' if you want to use it now and not wait til next beta:  http://www.voiceattack.com/unofficial

Thanks for the heads-up.  It was hanging up on the optional bit.  Should have caught that one o_O 

[mIRCon]

Ah... I see what's up.  Stupid programmer issue.  I'll have at least an, 'unofficial' out in a bit.


Edit:  There's a build out in, 'unofficial' if you want to use it now and not wait til next beta:  http://www.voiceattack.com/unofficial

Thanks for the heads-up.  It was hanging up on the optional bit.  Should have caught that one o_O

@Gary
I have encountered a bug with this 1.6.1.28 unofficial .exe release so I'm just letting you know.

If I try to edit some command (add or delete "When I say" line) I get exception after I click OK. If I click continue nothing happens and I get back into command editor where I can click cancel and it'll be ok or if I click ok and then quit when exception dialog appears then VA will crash-close.

Here is the screen shot of the error attached and the whole error text is:

Code: [Select]

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.ArgumentException: An item with the same key has already been added.
   at System.ThrowHelper.ThrowArgumentException(ExceptionResource resource)
   at System.Collections.Generic.Dictionary`2.Insert(TKey key, TValue value, Boolean add)
   at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
   at VoiceAttack.frmMain.
(List`1 , Int32 , String , Boolean , List`1 )
   at VoiceAttack.frmMain.
(List`1 , Int32 , String , Boolean , List`1 )
   at VoiceAttack.frmMain.
(List`1 , Int32 , String , Boolean , List`1 )
   at VoiceAttack.frmMain.
(String , Boolean )
   at VoiceAttack.frmMain.(String )
   at VoiceAttack.frmCommand.(Object , EventArgs )
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.NET/Framework/v4.0.30319/mscorlib.dll
----------------------------------------
VoiceAttack
    Assembly Version: 0.0.0.1
    Win32 Version: 1.6.1.28
    CodeBase: file:///C:/Program%20Files%20(x86)/VoiceAttack/VoiceAttack.exe
----------------------------------------
System.Core
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll
----------------------------------------
System
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Windows.Forms
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System.Drawing
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
ScintillaNET
    Assembly Version: 3.5.10.0
    Win32 Version: 3.5.10.0
    CodeBase: file:///C:/Program%20Files%20(x86)/VoiceAttack/ScintillaNET.DLL
----------------------------------------
PresentationFramework
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/PresentationFramework/v4.0_4.0.0.0__31bf3856ad364e35/PresentationFramework.dll
----------------------------------------
WindowsBase
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/WindowsBase/v4.0_4.0.0.0__31bf3856ad364e35/WindowsBase.dll
----------------------------------------
PresentationCore
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_32/PresentationCore/v4.0_4.0.0.0__31bf3856ad364e35/PresentationCore.dll
----------------------------------------
System.Xaml
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xaml/v4.0_4.0.0.0__b77a5c561934e089/System.Xaml.dll
----------------------------------------
System.Speech
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Speech/v4.0_4.0.0.0__31bf3856ad364e35/System.Speech.dll
----------------------------------------
System.Management
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Management/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Management.dll
----------------------------------------
System.Web
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_32/System.Web/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Web.dll
----------------------------------------
System.Configuration
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll
----------------------------------------
Microsoft.VisualBasic
    Assembly Version: 10.0.0.0
    Win32 Version: 14.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Microsoft.VisualBasic/v4.0_10.0.0.0__b03f5f7f11d50a3a/Microsoft.VisualBasic.dll
----------------------------------------
System.Xml
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
{d9cd170b-6f08-444d-a61c-28828630072f}
    Assembly Version: 0.0.0.0
    Win32 Version: 1.6.1.28
    CodeBase: file:///C:/Program%20Files%20(x86)/VoiceAttack/VoiceAttack.exe
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------
System.Data
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_32/System.Data/v4.0_4.0.0.0__b77a5c561934e089/System.Data.dll
----------------------------------------
Microsoft.CSharp
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Microsoft.CSharp/v4.0_4.0.0.0__b03f5f7f11d50a3a/Microsoft.CSharp.dll
----------------------------------------
bindEDplugin
    Assembly Version: 1.0.0.0
    Win32 Version: 1.0.0.1
    CodeBase: file:///C:/Program%20Files%20(x86)/VoiceAttack/Apps/HCSCustomerBinds/bindEDplugin.dll
----------------------------------------
EliteDangerousJournalReader
    Assembly Version: 1.0.0.0
    Win32 Version: 1.0.0.0
    CodeBase: file:///C:/Program%20Files%20(x86)/VoiceAttack/Apps/HCSJournalReader/EliteDangerousJournalReader.dll
----------------------------------------
Newtonsoft.Json
    Assembly Version: 9.0.0.0
    Win32 Version: 9.0.1.19813
    CodeBase: file:///C:/Program%20Files%20(x86)/VoiceAttack/Apps/HCSJournalReader/Newtonsoft.Json.dll
----------------------------------------
VAJS
    Assembly Version: 1.0.0.0
    Win32 Version: 1.0.0.2
    CodeBase: file:///C:/Program%20Files%20(x86)/VoiceAttack/VAJS.DLL
----------------------------------------
System.Dynamic
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Dynamic/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Dynamic.dll
----------------------------------------
Anonymously Hosted DynamicMethods Assembly
    Assembly Version: 0.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_32/mscorlib/v4.0_4.0.0.0__b77a5c561934e089/mscorlib.dll
----------------------------------------
System.Xml.Linq
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml.Linq/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.Linq.dll
----------------------------------------
Microsoft.WindowsAPICodePack.Shell
    Assembly Version: 1.1.0.0
    Win32 Version: 1.1.0.0
    CodeBase: file:///C:/Program%20Files%20(x86)/VoiceAttack/MSTaskBar.dll
----------------------------------------
System.Numerics
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Numerics/v4.0_4.0.0.0__b77a5c561934e089/System.Numerics.dll
----------------------------------------
System.Runtime.Serialization
    Assembly Version: 4.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Runtime.Serialization/v4.0_4.0.0.0__b77a5c561934e089/System.Runtime.Serialization.dll
----------------------------------------
Microsoft.GeneratedCode
    Assembly Version: 1.0.0.0
    Win32 Version: 4.6.1087.0 built by: NETFXREL4STAGE
    CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
    <system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

I'm using Windows 7 64bit on this machine.
The error doesn't appear if I switch .exe to 1.6.1.27 beta version and it re-appears when I switch again to 1.6.1.28 so it's easily reproducible.

[Gary]

Thanks for the heads-up.  I put a new build out there:  http://www.voiceattack.com/unofficial

Could you try that one and see if it fixes the issue?  I *think* I caught what would cause that.

[mIRCon]

Thanks for the heads-up.  I put a new build out there:  http://www.voiceattack.com/unofficial

Could you try that one and see if it fixes the issue?  I *think* I caught what would cause that.

@Gary
Yup, you fixed it. It's all good now, at least when it comes to editing commands hehe
Will use it until next beta or final release so I'll report if I stumble upon any new issues.

[Pfeil]

Posted here as it seems relevant:

Using the "{CMDSEGMENT:}" token in "Say Something with Text-To-Speech" and clicking "Preview" will freeze VoiceAttack.

This occurs in v1.6.1.30.

[Gary]

Thanks for letting me know.  The latest, 'unofficial' that was put out there last night should have that straightened out.

[Omnidon]

CMDSEGMENT does not work with derived contents of suffixes (even in the unofficial version)

All values are NOT SET

(I know that CMDSEGMENTs can be used to recreate the same effect, but it would still be nice if they worked with suffixes)

[Gary]

Hi, Omnidon.  Yep... you are correct.  The CMDSEGMENT token was not working with composite (prefix/suffix) commands.  That has been fixed and will be out in the next release.  Thanks for the heads-up on that one!

[kgw279]

wild card and variable command not working with CMDSEGMENT:

"open [bank,amazon]" - when i say "open bank" it is recognized

"*open [bank,amazon]" - when i say "computer please open bank" it is not recognized
"{open;go to} [bank,amazon]" - when i say "open bank" it is not recognized but "go to bank" is recognized

EDIT:
with "{open;go to} [bank,amazon]" - phrase "open bank" is recognized but it doesn't execute the command.
with "*open [bank,amazon]" - phrase "computer please open bank" is recognized but {CMDSEGMENT:1} is not set

i've tried a bunch of variations... let me know if you think this is a bug, outside of scope, or if my syntax is wrong. thanks!

[Pfeil]

"{open;go to} [bank,amazon]" - when i say "open bank" it is not recognized but "go to bank" is recognized

...None of this should work, because the syntax is wholly incorrect.

Curly braces ("{" and "}") have no place in a command name, they don't serve any purpose there.

Dynamic command segments use square brackets to encapsulate a segment, with semicolons separating the variations: "go to [bank;amazon]".


You do have a point in that wildcards stop the "{CMDSEGMENT:}" token from working, which may need to be looked at.


EDIT: It should be said that the "{CMDSEGMENT:}" token is not necessary to differentiate between command phrases, if sections can't(or aren't expected to) be repeated:

Code: [Select]

Begin Text Compare : [{CMD}] Contains 'bank'
Else
End Condition


[kgw279]

"{open;go to} [bank,amazon]" - when i say "open bank" it is not recognized but "go to bank" is recognized

...None of this should work, because the syntax is wholly incorrect.

Curly braces ("{" and "}") have no place in a command name, they don't serve any purpose there.

Dynamic command segments use square brackets to encapsulate a segment, with semicolons separating the variations: "go to [bank;amazon]".


You do have a point in that wildcards stop the "{CMDSEGMENT:}" token from working, which may need to be looked at.

ah right! i needed to do [open;go to] [bank;amazon] in order for "open bank" or "go to bank" to execute the command.  and yes, the wildcard still does not work even with the corrected syntax.

Thank you!