[v1.5.12.31] "{TXTSUBSTR}" crashes VoiceAttack when Length is negative

[Pfeil]

If the "{TXTSUBSTR}" token is given a negative Length, E.G. "{TXTSUBSTR:"Test":0:-1}" and used to write to the log, the command will run indefinitely and not produce output(the only indication it's running is a "Commands Running" warning when closing the "Edit a Profile" window).

However, if this same token is used to set a variable, E.G.

Code: [Select]

Set integer [Crash] value to the converted value of {TXTSUBSTR:"Test":0:-1}
VoiceAttack will freeze and run at 100% CPU(single core).


This does not occur when the start position is negative, nor does "{TXTPOS}" have the same issue. Perhaps a forgotten check on the last parameter of "{TXTSUBSTR}"?

[Gary]

Thanks for the heads-up.  I just got back from travelling, so I will take a look at this later this evening.

I threw this together for Jerry before I left town so he would have something to work with.  Hope that's the only thing holding it up

[Pfeil]

The crash no longer occurs. Solved.

One thing to note is that a negative value will be treated as 0.
For the "Begin" parameter, this means it will return from the start of the string onward.
However, when the "Length" parameter is set to a negative number, it will result in blank output.

[Gary]

Also 0 (length).

It's probably not going to happen that often, but I didn't want it to crash.

So, maybe if either is negative, the result is empty.

[Pfeil]

So, maybe if either is negative, the result is empty.

That would allow a user to include a check, where a blank is a likely error in a previous action, and throw a warning in the log. Makes sense.

[Gary]

Done.